Closed hiltontj closed 3 months ago
@Marcono1234 left some good suggestions on https://github.com/hiltontj/serde_json_path/pull/98 that should be addressed:
From
checked_abs
Option
Some
checked_*
mut self
&self
@Marcono1234 left some good suggestions on https://github.com/hiltontj/serde_json_path/pull/98 that should be addressed:
Fromimplementations (https://github.com/hiltontj/serde_json_path/pull/98#discussion_r1703317100)checked_absdoes not need to return anOption, it will always beSome(https://github.com/hiltontj/serde_json_path/pull/98#discussion_r1703318825)checked_*functions that takemut selfis a bit odd, it may be better to take&selfto avoid confusion and potential foot guns.