`JsonPath` type should implement more common traits - Githubissues

hiltontj / serde_json_path

Query serde_json Values with JSONPath

https://serdejsonpath.live/

MIT License

51 stars 4 forks source link

`JsonPath` type should implement more common traits #23

Closed hiltontj closed 1 year ago

hiltontj commented 1 year ago

For better API interoperability, the JsonPath type should implement more common traits, as per the Rust API Guidelines.

Implementing

[x] Clone
[x] Debug
[x] Display
[x] Serialize
[x] Deserialize
[x] PartialEq
[x] Eq - It is already implementing PartialEq, and I am not sure if Eq is relevant
[x] Default - could just be the root path query $

Not implementing

[x] Hash - not sure if this is relevant
[x] PartialOrd - I don't think this is relevant
[x] Ord - as with PartialOrd, I don't think this applies