search

hilverd / vagrant-ubuntu-oracle-xe

Install Oracle 11g XE in a Vagrant virtual machine running Ubuntu 12.04.
MIT License
287 stars 96 forks source link

Add flyway #20

Closed nblair closed 9 years ago

nblair commented 9 years ago

This pull request adds Flyway to the provisioning process to automate creation of tables and insertion of data.

Flyway is a Java application, so it does depend on the installation of Java and Maven. In order to connect Java with Oracle, one needs a JDBC driver, which of course Oracle does not distribute freely. That does mean the addition of one more download, which I've covered on the root README.

Some bits I'm not sure about:

  1. There are steps required on the host to install the Puppet forge modules for Java and/or Maven. Is there a way we can automate that? Do we need to includes those modules in git (I've gitignored them for now)?
  2. I was thinking it might be desirable to skip the Flyway provisioning steps if the customer chooses. Perhaps we can craft a way to skip those steps if oracle-jdbc/ojdbc6.jar is not present?
hilverd commented 9 years ago

This is great, thanks very much!

In response to your questions:

  1. We can actually install those modules on the VM, as that is where Puppet runs. I have added a small shell script to the Vagrantfile to do this before the Puppet provisioning.
  2. I agree. I have added some logic so that if ojdbc6.jar is not present, the steps to install the Java and Maven modules and run Flyway provisioning are skipped.

Thanks again :-).