himan-k / CodePath

CodePath Simple ToDo App
0 stars 0 forks source link

[Android Bootcamp] Prework - Simple ToDo App #1

Open himan-k opened 9 years ago

himan-k commented 9 years ago

My ToDo app is complete, please review. /cc @codepathreview @codepath

nesquena commented 9 years ago

Himanshu,

Looks good! This was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a personalized code review for each submitted project once the bootcamp starts.

The next step is to continue working on extensions to your todo app and to schedule a short 5-10 minute phone conversation here. Navigate to January 20th and dates onward and choose a 15-minute slot. Let us know if none of those times work.

Please make sure to include the best number to reach you at in the scheduled event? Look forward to chatting soon!

himan-k commented 9 years ago

Thanks, Nathan! I updated the app with a few extensions. Please take a look. Looking forward to talking to you in a few hours! /cc @codepathreview @codepath

nidhi1608 commented 9 years ago

Extensions look good, nice to see you got most of the basic suggested ones implemented. You should be hearing from us via a followup email in the next couple days.

You are using the new material design theme (Theme.AppCompat.Light.DarkActionBar) in your styles.xml file. Thats why you don't see the app icon in the action bar - thats the desired behavior and is also a change from previous versions of Android. Also, I do see the custom app icon when the app gets installed on my phone. Let me know if you have any other questions.