search

himanshu251001 / E-Commerce

If you are Looking for (UI) Designs and Effects for your Projects/websites, then this website is a one stop solution for you.
5 stars 7 forks source link

Fix bug by adding correct navigation path in the Landing Page #13

Closed sidhartha2002 closed 1 year ago

sidhartha2002 commented 1 year ago

Hey @himanshu251001 , I have fixed the bug in the traditional card. Kindly review it by accepting my pull request. Here is the glimpse of the working of traditional card in browser.

Before :

image

After :

https://user-images.githubusercontent.com/73163725/235508300-b9c4d0c5-947f-4582-ae07-16e0ef121ff5.mp4

sidhartha2002 commented 1 year ago

I have one query related to hamburger menu. What is the need of the hamburger in larger screen ? ? ?

As your designed website is already responsive, I would say that brand name / logo should be replaced with the hamburger icon present currently and rest will remain same. While the website is in smaller screen then all the navbar links except company logo should be transformed to hamburger icon enclosing all the navlinks inside it as dropdown.

If you don't mind its just a simple suggestion otherwise its your project and you know well about how to make your project work.

Thanks.

himanshu251001 commented 1 year ago

I have one query related to hamburger menu. What is the need of the hamburger in larger screen ? ? ?

As your designed website is already responsive, I would say that brand name / logo should be replaced with the hamburger icon present currently and rest will remain same. While the website is in smaller screen then all the navbar links except company logo should be transformed to hamburger icon enclosing all the navlinks inside it as dropdown.

If you don't mind its just a simple suggestion otherwise its your project and you know well about how to make your project work.

Thanks.

First of all it's a open source contribution platform,here people try to contribute to make projects better ,if you have any idea to make project better and you think it will work do the changes and send the request for approval. Now, coming back to your suggestion on hamburger icon it was kept for future use to add few more pages but it didn't happend , somebody wanted to add something then i approved that.