search

himanshub16 / ProxyMan

Configuring proxy settings made easy.
https://github.com/himanshub16/ProxyMan/releases/latest/
MIT License
683 stars 108 forks source link

added snap support #72

Closed tuxfy closed 3 years ago

tuxfy commented 5 years ago

maybe it's useful to combinate it with apt/dnf -> apt/dnf/snap

himanshub16 commented 5 years ago

Thanks @tuxfy This is helpful but seems redundant. It would be even better if we could model it the way shellrc.sh works with bash-zsh.sh. Something like systemctl-service.sh and snapd.sh, dockerd.sh.

himanshub16 commented 5 years ago

Also, I would suggest creating pull requests against v3 instead of master. That would help testing things out and managing releases.

tuxfy commented 5 years ago

Also, I would suggest creating pull requests against v3 instead of master. That would help testing things out and managing releases.

Ok. no problem :)

tuxfy commented 5 years ago

Thanks @tuxfy This is helpful but seems redundant. It would be even better if we could model it the way shellrc.sh works with bash-zsh.sh. Something like systemctl-service.sh and snapd.sh, dockerd.sh.

Ok, I understand your intention. I combinded it to apt+snap/dnf in my fork. Seems more logical in my opinion und more practical for my usage. So I can handle docker and package-managers separately.

Therefore maybe a combinded package-manager.sh would be a good solution for me ...

himanshub16 commented 5 years ago

Sorry for late reply. Got caught up in exams. Shall review and merge next week.

tuxfy commented 5 years ago

No problem. Here is an updated version. https://github.com/tuxfy/ProxyMan/blob/master/dists/snap.sh Added missing touch command for initial creating the conf file