search

himanshub16 / ProxyMan

Configuring proxy settings made easy.
https://github.com/himanshub16/ProxyMan/releases/latest/
MIT License
690 stars 107 forks source link

~/.gitconfig proxy setting is not cleaned #81

Closed mebble closed 5 years ago

mebble commented 5 years ago

When we run proxyman unset, the lines in ~/.gitconfig

[http]
    proxy = https://172.31.2.4:8080/
[https]
    proxy = https://172.31.2.4:8080/

turn into

[http]
[https]

On setting the proxy later on, these lines persist i.e. the gitconfig file becomes

[http]
[https]
[http]
    proxy = http://172.31.2.4:8080/
[https]
    proxy = https://172.31.2.4:8080/

This results in many of these lines over time

proxyman version v3.1.2 on Ubuntu 18.04

himanshub16 commented 5 years ago

Sounds similar to #75, where it was due to older version of git behaving as such. Newer version of git (perhaps 2.18, as mentioned here) have fixed this.

This was why I decided to not fix this in #75, as it is bound to fade with coming updates. Let me know if your issue is a different one.

mebble commented 5 years ago

Yup, I'm using git v2.17.1 and was able to replicate the problem shown at that stackoverflow post you linked. Closing this issue.