search

himanshub16 / ProxyMan

Configuring proxy settings made easy.
https://github.com/himanshub16/ProxyMan/releases/latest/
MIT License
683 stars 108 forks source link

Restore and adapt environment.sh script #89

Closed danielemegna closed 4 years ago

danielemegna commented 4 years ago

Restore and adapt environment.sh script. This close issue #78.

This pull request has been developed during Open Source Saturday #28 meetup in Milan.

Open Source Saturday

himanshub16 commented 4 years ago

Thanks a lot @danielemegna This works. But we could rather try using bash-zsh.sh which in-turn calls shellrc.sh. That'll also require main.sh to be updated to call bash-zsh.sh with sudo privilege. That reduces the amount of code to maintain.

danielemegna commented 4 years ago

Thanks a lot @danielemegna This works. But we could rather try using bash-zsh.sh which in-turn calls shellrc.sh. That'll also require main.sh to be updated to call bash-zsh.sh with sudo privilege. That reduces the amount of code to maintain.

I agree. But I thought that the priority was to quickly restore a working version :) Currently a bad massage is shown and a core functionality is missing.

danielemegna commented 4 years ago

hey @himanshub16 , can we evaluate this hotfix? the current version does not work :(

himanshub16 commented 4 years ago

Made a fix in #94 Let me know if it there's any issue.

danielemegna commented 4 years ago

Made a fix in #94 Let me know if it there's any issue.

Seems to work!