himanshub16 / ProxyMan

Configuring proxy settings made easy.
https://github.com/himanshub16/ProxyMan/releases/latest/
MIT License
683 stars 108 forks source link

Add macOS support #96

Open deg0nz opened 4 years ago

deg0nz commented 4 years ago

I added the support for macOS for ProxyMan. I created this PR so we can discuss some stuff about the implementation.

For now, the following things are implemented:

What's missing:

To be done/discussed before merging:

deg0nz commented 4 years ago

I tried the macOS version on another machine today. Turns out, that realpath (readlink -f equivalent for BSD) does not come with macOS per default. It seems that I had installed coreutils a long time ago (and forgot about it), so it worked out of the box on my machine. I added a shell-only substitute that I found on here on GitHub.

himanshub16 commented 4 years ago

Thanks a lot @deg0nz Your contribution is really helpful and adds a lot of value by providing support on MacOS.

I'm sorry for not responding. There has been some delay from my end as I had been occupied. Will definitely have a look at this later this week/during weekend.

deg0nz commented 4 years ago

No problem, take your time :) I'm currently using my fork at work and found some quirks here and there. I need to do some more testing with the networksetup part. So no need to rush :)

deg0nz commented 4 years ago

Okay, I fixed the problem with the networksetup part and everything seems to work on macOS as far as I tested it. I also tested the changes on a Linux machine (My LinuxMint VM) and everything works as expected.

From my perspective, this is ready to merge now. Any tests and suggestions for improvements are appreciated, of course :)

FatehAK commented 3 years ago

Has this feature been merged? Does proxyman support macos now?

deg0nz commented 3 years ago

@FatehAK Unfortunately it is not merged yet, but you can just use my fork by using the macOS branch until it gets merged.

I'm using this for almost a year now and it seems to be working fine. I would also be happy if someone else could test this :)

FatehAK commented 3 years ago

It works perfectly @deg0nz. I've used it for the past few days haven't faced any issues.

deg0nz commented 2 years ago

Just FYI:

Me and my colleagues are using this for almost 2 years now without any problems. I think it can be considered stable