himanshusharma89 / relic_bazaar

A Retro Theme-based e-commerce app for antiques. #Hack20
https://relic-bazaar.himanshusharma.tech/
Creative Commons Zero v1.0 Universal
85 stars 92 forks source link

Password Visibility Icons on Authorization pages are inverted #258

Closed Atharv-Joshi closed 2 years ago

Atharv-Joshi commented 2 years ago

Bug Report πŸ›

Visibility Icons in Authorization pages are inverted

When password is hidden the icon should be Screenshot 2021-11-10 004639 while it is Screenshot 2021-11-10 004719 Also the colors aren't consistent with app theme

Expected Behavior

When password is hidden the icon should be Screenshot 2021-11-10 004639 while it is Screenshot 2021-11-10 004719 When password is visible the icon color can be warning color and if hidden it can be primary color or background color

Screenshot 2021-11-10 005440

I would also like to add a back button to login page from sign up page as is already present from login to signup

Current Behavior

When password is hidden the icon is Screenshot 2021-11-10 004719 instead of Screenshot 2021-11-10 004639 Also the colors aren't consistent with app theme

Possible Solution

inverting icon names in codebase

Steps to Reproduce

  1. No specific conditions needed.
  2. IS present on Login and Signup Page

Context (Environment)

Desktop

Detailed Description

Possible Implementation

welcome[bot] commented 2 years ago

Hello there!πŸ‘‹ Welcome to the project!πŸš€βš‘ Thank you and congratsπŸŽ‰ for opening your very first issue in this project. Please make sure to go through our Code of Conduct and contributing files and also please wait till you are assigned an issue to start working on it.😊

Atharv-Joshi commented 2 years ago

Can I work on this?

warpaltarpers commented 2 years ago

I don't think this is a bug; while "flip-flop" buttons like the one in question aren't considered the best option because they don't tell you the current state, the standard is that the icon should show what will happen when you click/tap on it. So, the current behavior lines up with the standard.

Atharv-Joshi commented 2 years ago

Yeah , the button state confused me for a second while exploring the app , ig something like show/hide would be more appropriate?

himanshusharma89 commented 2 years ago

Hi @Atharv-Joshi, pardon me for the delayed response. Sure, you can work on this.

Atharv-Joshi commented 2 years ago

Hi @Atharv-Joshi, pardon me for the delayed response. Sure, you can work on this.

No problem!