himanshusharma89 / relic_bazaar

A Retro Theme-based e-commerce app for antiques. #Hack20
https://relic-bazaar.himanshusharma.tech/
Creative Commons Zero v1.0 Universal
86 stars 92 forks source link

Cart System Implemented #260

Open Atharv-Joshi opened 2 years ago

Atharv-Joshi commented 2 years ago

Related Issue

Closes #248

Proposed Changes

Known Issues

Checklist

Screenshots

cart system shimmer

welcome[bot] commented 2 years ago

Hello there!πŸ‘‹ Welcome to the project!πŸ’– Thank you and congratsπŸŽ‰ for opening your first pull request. Please make sure you have gone through our Code of Conduct and contributing files before making this pr. πŸ™ŒπŸ™Œ We will get back to you as soon as we can πŸ˜„.

himanshusharma89 commented 2 years ago

Hi @Atharv-Joshi, can you tell me how dis you choose get over other state management tools?

Atharv-Joshi commented 2 years ago

Hi @Atharv-Joshi, can you tell me how dis you choose get over other state management tools?

actually i was just trying out getx here and forgot to delete that code in pr I chose getx as its lightweight I've added a commit which removes all getx related code and follows type annotations where mentioned

Atharv-Joshi commented 2 years ago

I'll also add the price in payment window in this PR itself.

himanshusharma89 commented 2 years ago

Sure @Atharv-Joshi, just tag me when done, because GitHub notifications got skipped from my inbox earlier.

Atharv-Joshi commented 2 years ago

sure!