search

himdel / ansible-hub-ui

Ansible Automation Hub UI
0 stars 0 forks source link

[rbac] Unify RolePermissions component - replace other versions #4

Closed himdel closed 2 years ago

himdel commented 2 years ago

RolePermissions comes from d8e4f75446c5f3965ea24c0970c269bec9648311 (ansible/ansible-hub-ui#1863), taken from src/containers/group-management/group-detail-role-management/group-detail-role-management.tsx

But the same logic also appears in: src/components/role-management/role-form.tsx src/components/role-management/role-permissions.tsx src/containers/role-management/role-list.tsx

with variations on editability, showing extra permissions, and hiding empty permission groups.

=> setPermissions, showCustom, showEmpty on RolePermissions :)

himdel commented 2 years ago

Moved to https://github.com/ansible/ansible-hub-ui/pull/2246