search

himdel / ansible-hub-ui

Ansible Automation Hub UI
0 stars 0 forks source link

Sign button change on certificate upload #5

Closed brumik closed 2 years ago

brumik commented 2 years ago

https://issues.redhat.com/browse/AAH-1369 - update

When the flag can_upload_signatures is set it takes precedence over the backend signing. Therefore we are hiding the Sign all buttons on the collection and namespace detail pages, and changing the Sign version x.x to bring up the certificate upload modal.

In addition it fixes the waitForTask function to return error if the task is not running and not completed so we can report failures.

After with the can_upload_signatures = true: Screenshot from 2022-06-20 13-06-02 Screenshot from 2022-06-20 13-06-42 Screenshot from 2022-06-20 13-07-09 Screenshot from 2022-06-20 13-07-15 Screenshot from 2022-06-20 13-07-31 Screenshot from 2022-06-20 13-08-41

brumik commented 2 years ago

@himdel I will rebase/reopen the PR against ansible when your PR gets merged.

himdel commented 2 years ago

:+1: looks good :)