hime-ime / hime

HIME Input Method Editor
http://hime-ime.github.io
267 stars 48 forks source link

multiple changes in debian build workflow #750

Closed Brli closed 3 years ago

Brli commented 3 years ago
marktwtn commented 3 years ago
* command: apt -> apt-get, which doesn't use interactive dialog

Doesn't the option --yes have solved the problem of interactive dialogue?

xatier commented 3 years ago
* command: apt -> apt-get, which doesn't use interactive dialog

Doesn't the option --yes have solved the problem of interactive dialogue?

+1, I'm not sure why using apt-get would help here?

marktwtn commented 3 years ago

@Brli can you revert the modification related to apt?

xatier commented 3 years ago

@marktwtn did you see any regressions?

marktwtn commented 3 years ago

Nope. I think after the apt-get is reverted to apt, we can merge this pull request.

Brli commented 3 years ago

Well, you don't need to append yes to interactive dialog to mimic straight forward ci, just use the non-interactive command directly.

marktwtn @.***> 於 2021年5月13日 週四 下午6:15 寫道:

Nope. I think after the apt-get is reverted to apt, we can merge this pull request.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hime-ime/hime/pull/750#issuecomment-840462666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA626RWIKBCZ3E3RDZEYXSTTNORFVANCNFSM42SWMWGA .

marktwtn commented 3 years ago

I checked the manual of apt-get and apt. It turns out that the --yes option is only available in apt-get. The --yes in apt does not have any affect.

If there is no question, I think the pull request can be merged.

marktwtn commented 3 years ago

@Brli after you fix the typo, we can merge the pull request. Thanks for helping again.