Value changes when new props is given

himelbrand / react-native-numeric-input

a stylish numeric input for react native

MIT License

148 stars 102 forks source link

Closed mattyx96 closed 6 years ago

himelbrand commented 6 years ago

@mattyx96 please explain what this PR will add to the library. I need to understand your change before I'll merge

mattyx96 commented 6 years ago

I added 2 lines for the value number string update when new props passed without unmount the component in componentDidUpdate of numericInput.js

himelbrand commented 6 years ago

@mattyx96 have you tested to check that the original functionality remained intact ?

mattyx96 commented 6 years ago

@himelbrand I m using the modified library on an app and all seems to work well

himelbrand commented 6 years ago

@mattyx96 merged! thank you for contributing.