search

himelbrand / react-native-numeric-input

a stylish numeric input for react native
MIT License
148 stars 102 forks source link

Use TextStyle for iconStyle #55

Open peterkuiper opened 4 years ago

peterkuiper commented 4 years ago

Fixes #53

himelbrand commented 2 years ago

Thanks a lot for your contribution! Please make it possible to use one or the other... depending on need

jarod-legault commented 4 months ago

@himelbrand I'm not sure why there should be an option of different types for iconStyle. If you look at IconProps from react-native-vector-icons/Icon, it extends TextProps from react-native, which in turn uses TextStyle for the style prop. It seems like this PR is correct and will eliminate Typescript errors for users, specifically when attempting to set the color of the icons. But maybe I am misunderstanding your comment.