Open liveafto opened 2 months ago
any news?
Sadly im pretty sure this repo is no longer mentained as i also raised 2 issues a few months ago. I am considering making a fork.
This error occurs because the icons "md-remove" and "md-add" do not exist. To fix this, you should change the icon names to "remove" and "add".
npm uninstall react-native-numeric-input
npm install BlueRacoon/react-native-numeric-input
@BlueRacoon If you did the fork can you please also address some MAJOR bugs like the limit reached callback being inverted (isMax is true for the lower limit and vice versa for keyboard input only, for button input it works as intended) See pull request: https://github.com/himelbrand/react-native-numeric-input/pull/95
And also the lack of a minus sign on iOS for inputing negative numbers (see: https://github.com/himelbrand/react-native-numeric-input/pull/97)
Thank you! @BlueRacoon
@BlueRacoon If you did the fork can you please also address some MAJOR bugs like the limit reached callback being inverted (isMax is true for the lower limit and vice versa for keyboard input only, for button input it works as intended) See pull request: #95
And also the lack of a minus sign on iOS for inputing negative numbers (see: #97)
Please see and review here :) https://github.com/BlueRacoon/react-native-numeric-input/commit/c9247a3b176646a6bce618d3e659045757e88f3e https://github.com/BlueRacoon/react-native-numeric-input/commit/0eeb1894d7296bc679295b41d8271e92b0b2240e
@rares-nandra
@BlueRacoon you can commit the changes. Thank you!
Wondering if there is any chance to upgrade react-native-vector-icons to v10 version, the Ionicons names of md-add, md-remove, ios-arrow-up, ios-arrow-down of v10 version will be changed.