himelbrand / react-native-numeric-input

a stylish numeric input for react native
MIT License
150 stars 97 forks source link

[Feature request] - Upgrade react-native-vector-icons to v10 #99

Open liveafto opened 2 months ago

liveafto commented 2 months ago

Wondering if there is any chance to upgrade react-native-vector-icons to v10 version, the Ionicons names of md-add, md-remove, ios-arrow-up, ios-arrow-down of v10 version will be changed.

截圖 2024-04-22 下午2 01 15
joaolenosi commented 2 months ago

any news?

rares-nandra commented 1 month ago

Sadly im pretty sure this repo is no longer mentained as i also raised 2 issues a few months ago. I am considering making a fork.

Bryan47749 commented 1 month ago

This error occurs because the icons "md-remove" and "md-add" do not exist. To fix this, you should change the icon names to "remove" and "add".

image

BlueRacoon commented 1 month ago

npm uninstall react-native-numeric-input

npm install BlueRacoon/react-native-numeric-input

rares-nandra commented 1 month ago

@BlueRacoon If you did the fork can you please also address some MAJOR bugs like the limit reached callback being inverted (isMax is true for the lower limit and vice versa for keyboard input only, for button input it works as intended) See pull request: https://github.com/himelbrand/react-native-numeric-input/pull/95

And also the lack of a minus sign on iOS for inputing negative numbers (see: https://github.com/himelbrand/react-native-numeric-input/pull/97)

dmi3y commented 1 month ago

Thank you! @BlueRacoon

BlueRacoon commented 1 month ago

@BlueRacoon If you did the fork can you please also address some MAJOR bugs like the limit reached callback being inverted (isMax is true for the lower limit and vice versa for keyboard input only, for button input it works as intended) See pull request: #95

And also the lack of a minus sign on iOS for inputing negative numbers (see: #97)

Please see and review here :) https://github.com/BlueRacoon/react-native-numeric-input/commit/c9247a3b176646a6bce618d3e659045757e88f3e https://github.com/BlueRacoon/react-native-numeric-input/commit/0eeb1894d7296bc679295b41d8271e92b0b2240e

@rares-nandra

rares-nandra commented 3 weeks ago

@BlueRacoon you can commit the changes. Thank you!