himoto / hillfit

Fitting the Hill Equation to Experimental Data
MIT License
11 stars 4 forks source link

view_figure argument not working in fitting() function #25

Closed timbo112711 closed 1 year ago

timbo112711 commented 1 year ago

When calling hf.fitting() the view_figure argument is not working. Either bool, True or False, displays the figure. I am trying to use this package in a Dash app and just need the x_fit, y_fit, and ec50 values for plotting a Plotly line chart.

himoto commented 1 year ago

Hello @timbo112711, thank you for your inquiry. Hi @freiburgermsu, can you please check this?

freiburgermsu commented 1 year ago

Hello @timbo112711 !

Some IDEs automatically render figures, despite when the figures are not explicitly called. Try setting generate_figure=False, which will prevent the figure from ever being created yet will still yield the contents that you desire.

The forthcoming updates have some additional functionality to help your workflow.

Andrew

himoto commented 1 year ago

Hi @timbo112711, We have updated master branch to try to resolve this issue. To try this out, please install hillfit via:

$ pip install git+https://github.com/himoto/hillfit

Please do let me know if this works.

timbo112711 commented 1 year ago

Hi @freiburgermsu !!

That arg worked like a charm. Can't believe I overlooked that one.

@himoto , Will do thanks!