search

himoto / hillfit

Fitting the Hill Equation to Experimental Data
MIT License
11 stars 4 forks source link

Updates #8

Closed freiburgermsu closed 2 years ago

freiburgermsu commented 2 years ago

Hello!

I saw that you updated the Hillfit PyPI page. I made the following edits as I have been using the module and improving the functionality. These updates would benefit PyPI users of the module. The unit-test and README reflect these updates.

Everything in this PR is debugged -- including the GitHub Action -- and fully operational.

Thank you :) Andrew

himoto commented 2 years ago

Hello @freiburgermsu , Thank you for the pull request. Can you please pull the latest upstream/master before committing your updates? Then, you can resolve merge conflicts.

Note: it is not good to work on the master branch and would be better to create new branch. https://stackoverflow.com/questions/5713563/reasons-for-not-working-on-the-master-branch-in-git

freiburgermsu commented 2 years ago

Hello @himoto ,

I merged our branches. I believe that adopted all of your changes. I restated r_2 in the Class object, which is a trivial change yet provides an essential feature that I use in one of my projects.

The Actions from my last push all passed, which suggests that the code has been successfully merged.

I will investigate creating another branch.

Andrew

lgtm-com[bot] commented 2 years ago

This pull request introduces 3 alerts when merging 909f3d93f2509f13ec9d6c160dcc1a52c2e83cc7 into c76143f7e09ea0d1ec4534134aeb4aaca83d79a0 - view on LGTM.com

new alerts:

himoto commented 2 years ago

Thanks, @freiburgermsu !