When parsing dependencies, we should allow broken ones

himselfv / viper

Enhanced Windows Service manager application

29 stars 2 forks source link

When parsing dependencies, we should allow broken ones #34

Closed himselfv closed 5 years ago

himselfv commented 5 years ago

Currently if Viper finds a broken dependency (a reference to a service which doesn't exist) it shows an error and does not display any dependencies at all.

This is unhelpful. Broken dependencies may happen and people would want to figure them out. Right now it doesn't even provide the missing service name.

It should instead just add this dependency as an error, with a cross to it.

himselfv commented 5 years ago

Done, only I'm slightly dissatisfied with that it's a bit non obvious.

Maybe:

A big red cross over the icon
A separate style for broken dependencies? Currently using the style for disabled services, it fits but a separate one would also be good.

himselfv commented 5 years ago

Changed the icon to a random white page + red cross from shell32. Won't bother with the style as there are usually a few such things at most; not worth caring about.