search

himselfv / wakan

Japanese and Chinese learning tool with dictionary
36 stars 7 forks source link

Text selection bugs when selecting pinyin in dictionary search results #137

Closed himselfv closed 11 years ago

himselfv commented 11 years ago

Original report by me.

Originally reported on Google Code with ID 137

When Wakan is configured to show pinyin and we select it in dict search results, selection
rectangle is drawn and the text is copied like there's still bopomofo instead of pinyin.

Probably we're storing wrong text as a "text for this cell".

Reported by himselfv on 2013-03-27 10:25:51

himselfv commented 11 years ago

Reported by himselfv on 2013-04-03 11:53:52

himselfv commented 11 years ago 
It seems that the registered painted text is correct, but we assume that every character
is full-width, thus drawing errors.
This also happens when full-width bopomofo contains variable-width latin/tone mark
inserts.

Reported by himselfv on 2013-04-03 13:56:25

himselfv commented 11 years ago

Reported by himselfv on 2013-04-03 13:56:54

himselfv commented 11 years ago 
Started fixing this. Of the two functions, DrawGridUpdateSelection is done (although
heavily dependent on that we only use it for one type of cells: fontface and kana/romaji
selection are taken from program-wide values, not per-cell/line).

PaintBoxUpdateSelection, FindDrawReg is yet to be converted. DrawReg stores fontname
now though.

Reported by himselfv on 2013-04-04 13:56:54

himselfv commented 11 years ago 
Probably fixed in @r469

Reported by himselfv on 2013-04-05 12:08:13

himselfv commented 11 years ago

Reported by himselfv on 2013-04-05 12:08:22