search

himselfv / wakan

Japanese and Chinese learning tool with dictionary
39 stars 7 forks source link

When Wakan is configured to show reading in romaji, reading is always shown over some hiragana #150

Closed himselfv closed 11 years ago

himselfv commented 11 years ago

Original report by me.

Originally reported on Google Code with ID 150

Apparently that's a side effect of FixReading() function: even if originally reading=='',
FixReading assigns reading for kana triples (shu, sha, etc)

Reported by himselfv on 2013-04-15 11:19:19

himselfv commented 11 years ago

Reported by himselfv on 2013-04-19 12:45:32

himselfv commented 11 years ago 
Title clarification.

When Wakan is configured to show reading in romaji, it always shows reading over some
hiragana syllables (namely, over combined hiragana: shu, sha, etc).
This happens even when just typing text in, before any suggestions and replacements
have taken place.

Reported by himselfv on 2013-04-22 11:44:58

himselfv commented 11 years ago 
Fixed @r504. This was not a bug but a feature, albeit incompletely implemented one.
In romaji annotation mode, all kana is annotated, even hiragana. Certain accommodations
need to take place to draw romaji nicely (for instance, sokuons -- small tsu to denote
doubled characters -- have to be treated differently).

Bugs were fixed and now this works as intended, by properly annotating all kana with
romaji.

Reported by himselfv on 2013-04-22 12:41:15

himselfv commented 11 years ago

Reported by himselfv on 2013-04-22 12:56:01