search

himselfv / wakan

Japanese and Chinese learning tool with dictionary
38 stars 7 forks source link

LEARNED state not updating correctly in Kanji List #272

Closed himselfv closed 9 years ago

himselfv commented 9 years ago

Original report by Anonymous.

Originally reported on Google Code with ID 272

On the newest version I encountered the issue that putting Kanji into the LEARNED Category
does not immediately change their color in the main Character List window. It only
updates immediately in the character details window.

This is important, because you can use CTRL + L to mark a Kanji as LEARNED without
opening the Details window, but since it doesn't update immediately or at all until
you switch to another window completely, there isn't any visual indication that the
Kanji has been put into the LEARNED category.

This is the bug, but I also suggest a small enhancement: colors don't seem to show
when you have a Kanji selected. So to see if the Kanji has changed category you have
to deselect it by selecting another Kanji or clicking elswhere.
Maybe we could add a Check Mark that appears upon CTRL + L and goes away when you deselect
(because then you would see the changed color).

Thx for considering and btw. I would like to become a regular committer. If you can
use my help, let me know.

Reported by supermarkus420 on 2014-12-27 10:01:33

himselfv commented 9 years ago 
Bug confirmed and fixed in r#027b761def14. This also makes the list auto-reload if it's
filtered by group and you add/remove kanji from that group.

Regarding your suggestion, I tried something a bit different in r#b8cc0ce6cda1: highlight
now inverts the cell colors. Learned cell when highlighted will be blue background,
white text (in default colors). Comments welcome.

About being a regular committer, sure! I've added you to committers, please just work
on whatever you like. If you need help on code structure (there's a lot of dark legacy),
I'm available here or over mail/jabber.

Reported by himselfv on 2015-02-12 17:06:27

himselfv commented 9 years ago

Original comment by Anonymous.

Thx.

I verified the fixing of the above bugs. Works splendidly

Reported by supermarkus420 on 2015-08-08 12:18:02