himselfv / wakan

Japanese and Chinese learning tool with dictionary
36 stars 7 forks source link

L10n Issues: Issues in .lng File #275

Closed himselfv closed 9 years ago

himselfv commented 9 years ago

Original report by Anonymous.

Originally reported on Google Code with ID 275

Ok. So I kind of envisioned this one as a meta-bug, as I work on an updated german and
a japanese localization for Wakan. These issues have to do with the en.lng file for
the englisch l10n. It's mostly small stuff I came accross, but this could prove useful
for future helping hands.

First thing I came accross:

for example sentences there are two buttons on the very right. Both are (mistakenly)
labeled "All" but the top one copies your current example to clipboard and the bottom
one only the very last one. When translating and choosing a suitable relabeling I found
that 00728 is the label for 00727 (which is the tooltip). This one is the top "All"
and should be something akin to "this".

The bottom one has 00729 as tooltip but the button label is 00670 (this one could be
renamed "Last" for instance)

Reported by supermarkus420 on 2015-03-07 11:42:02

himselfv commented 9 years ago

Original comment by Anonymous.

Oh, I forgot. These improvements I can tackle on my own, but I need to know if changing
l10n lines at random messes up the program (I guess it does). 

Also when tackling a japanese version, is it possible to create a japanese .lng file
for encoding reasons?

Lastly: 00726 seems to be the natural place for the button label of the top button.
right now it puts some text over the small "hand with index finger"-"go to example..."
pointer and obscures it, making it useless atm.

Reported by supermarkus420 on 2015-03-07 11:48:08

himselfv commented 9 years ago
> for example sentences there are two buttons on the very right. Both are (mistakenly)
labeled "All"

They aren't in my copy though. Top one is labelled "This". Here's how that place looks
in my en.lng file:

00726>Clip
00727>Copy example to clipboard
00728>This
00729>Copy all examples to clipboard

If what Mercurial is telling me is correct, it has long been this way (at least since
a year ago). Please try updating en.lng to the newest version?

> but I need to know if changing l10n lines at random messes up the program (I guess
it does). 

What do you mean? So far as you just fix a mistake or change wording, it shouldn't
mess anything. Just run it and check that it works fine.

If you're worried that some lines may be used in several different places, just run
a textual search over Wakan code for line id + "^" (e.g. "00727^"). With new lines
I try not to reuse anything (e.g. even if two different places read the same, I'll
make different entries for them).

> is it possible to create a japanese .lng file for encoding reasons?

So far as I remember it is. Just save it as UTF8 with Byte-order mark, or UTF16-LE.
If anything goes wrong, tell me and I'll check it out.

> 00726 seems to be the natural place for the button label of the top button. right
now it puts some text over the small "hand with index finger"-"go to example..." pointer
and obscures it, making it useless atm.

Yep, that label was in the wrong place. It's meant to be above the "All" and "This"
buttons and read "Clip", like this:
  Clip
  [This]
  [All]
I've fixed it in the commit #35340be14c7c.

Reported by himselfv on 2015-03-07 18:01:48

himselfv commented 9 years ago

Original comment by Anonymous.

Oops, sorry. going back to english file I see that indeed there is "This" and "All".
en.lng is the current one for this version. I misremembered

"This" copies the current example to clipboard, but! "All" only copies the very last
one, I checked by pasting. So either the functionality is off, or the label should
read "last" (at least in my copy).

Here's what I mean with less noise: The lng. File reads currently like this

00670>All '(this is "All" label and should ideally be at 00728
00726>Clip '(this is "Clip" which you now changed in commit, maybe put this at 00725
for maximum understandability?)
00727>Copy example to clipboard
00728>This '(this would be more intuitive at 00726)
00729>Copy all examples to clipboard '(tooltip correct, but functionality is off)

File should ideally read like this:

00725>Clip
00726>This
00727>Copy example to clipboard
00728>All OR Last
00729>Copy all examples to clipboard OR Copy last example to clipboard

By "messing Wakan up" I mean, if I change the identifying number (like 00670 -> 00725):
could this throw off the program, as it points to these identifiers?

Thx for the heads up, by the time we get to 2 (or even before) I'll have both translations
ready.

Reported by supermarkus420 on 2015-03-08 08:56:51

himselfv commented 9 years ago
> File should ideally read like this:

I see. That indeed is not viable. It can be done, but IDs have to be changed in both
code and all existing Wakan translations, which is a lot of mistake-prone work for
only aesthetic benefit.

Moreover, once we put everything in order, next time a button is added to Examples
panel, its caption will again be out of order, at the end of the translation list.

This could have been avoided by employing a different translation scheme, e.g. using
not numbers but component + property names, but those have their own drawbacks.

> "This" copies the current example to clipboard, but! "All" only copies the very last
one, I checked by pasting. So either the functionality is off, or the label should
read "last" (at least in my copy).

Confirmed, fixed in rev. #000f57cf1d6f, thanks. I'll try to put the latest executable
version here if you're not building it yourself:

http://googledrive.com/host/0B0jSbSrihj-yRDN4WlJXS05BOVE/Jalet.exe

Reported by himselfv on 2015-03-08 09:45:40

himselfv commented 9 years ago

Reported by himselfv on 2015-03-08 10:02:50