himselfv / wakan

Japanese and Chinese learning tool with dictionary
36 stars 7 forks source link

"learned only" menu item not selectable #277

Closed himselfv closed 9 years ago

himselfv commented 9 years ago

Original report by Anonymous.

Originally reported on Google Code with ID 277

Another issue I came accross. In the Character Menu after "Display all" there is "learned
only" and then "common only".
Now, the "learned only" one cannot be selected and has no effect when pressed.

I have a small number of Kanji in the LEARNED category.

Reported by supermarkus420 on 2015-03-08 11:52:48

himselfv commented 9 years ago
Confirmed. What do we do with this though? There's already a way to filter for LEARNED
kanji: open Groups, check "LEARNED". I can make "Learned only" just set that check,
but there's a catch:

A.
Category filter can be "In all of", "In any of" and "Not in any of". If it's set to
"All of", then checking "LEARNED" does what you'd expect from that menu item: additionally
filters by LEARNED. But if it's "Any of", then checking LEARNED just *adds* learned
kanji to the list, not restricts by them. (And if it's "Not in any", then learned kanji
are excluded which is even less excepted)

B.
I can implement this filter separately, but that would be two filters doing the same
thing. People will be confused. "I unchecked LEARNED in the list, but still only see
learned kanji" - "That's because you need to go to menu and uncheck it there too".

C.
When "Learned only" is checked, I may force switch to "In all of" mode. This is confusing
too, but at least if you look at your filters, you may understand what happened.

D.
I may just remove that menu item and leave only Grops filtering. Some say good design
is when there's only one way to do anything.

Reported by himselfv on 2015-03-11 10:08:09

himselfv commented 9 years ago

Original comment by Anonymous.

Considering what you said, and checking the menus again, I would think that D is the
best choice, as the group filtering has more functionality and complexity than can
be reached with one button. So if the implementation of the button is no longer viable
(that explains why only this button was broken), then we should remove it. Groups are
a more than adequate replacement.

Reported by supermarkus420 on 2015-03-11 11:34:05

himselfv commented 9 years ago
Done then. Though I'm kinda not satisfied with how non-obvious category filtering is
now (after earlier kanji list interface rehash). The fact that it is present at all
is hidden behind the "Groups" button, "In all of/In any of" combobox is confusing,
overall the feature is non-inviting. One day it will have to be rethought...

Reported by himselfv on 2015-04-15 10:24:46