himselfv / wakan

Japanese and Chinese learning tool with dictionary
38 stars 7 forks source link

Recover old quick look up functions in the text editor #286

Closed himselfv closed 6 years ago

himselfv commented 6 years ago

Original report by valg.

Is it possible to recover the quick look up functions in the text editor? I've been using Wakan for about ten years, but I use it exclusively as a quick dictionary, where I copy-paste the text I'm reading, click before the word I want to look up in the dictionary and have Wakan give me the results right away. I'd like to upgrade to the most recent version, but I can't, since it seems it lost this useful function (the only one I need Wakan for), as it searches only single words: if there's another word right after the one you're searching, it simply won't recognize it. Here's an example: https://i.imgur.com/WUo4m7z.png If I click before the word I want to look up I have its translations in the old Wakan, but not in the new one. Plus, in the old version the program shows the Character details of the last kanji I searched in this way, while the new one won't. Moreover, if I click before the word 気を付けて, for example, the old version gives me translations for 気を付けて, 気を付ける, 気を付け and 気. The new version gives me only 気を付けて and 気を付ける.

Another thing that bugs me is the fact that if I go back to the Characters tab the program will show me the last character I searched by clicking before it in the editor, while the new Wakan won't. This is probably related to the fact it doesn't show the Character details. https://i.imgur.com/PtayD5z.png

I think all of these are bugs. I simply can't update to the new version and use Edict2 only because of these.

himselfv commented 6 years ago

Confirmed, I'll see what I can do.

himselfv commented 6 years ago

Original comment by valg.

Thanks. Other than that, another thing I'd like to see is the support of the Kunrei system to write these characters: しちぢつづふ (si, ti, di, tu, du, hu) しゃちゃじゃぢャ (sya, tya, zya, dya) しゅちゅじゅぢュ (syu, tyu, zyu, dyu) しょちょじょぢョ (syo, tyo, zyo, dyo)

Well, I added all the characters that can't be written using that system, but the only ones I really need (because I write them using the Kunrei system, since it's way faster) are しちぢつづ (si, ti, di, tu, du) and the compounds of づ (ぢャぢュぢョ dya, dyu, dyo). Actually, it seems there's no way to write づ in the new Wakan, as "du" becomes どぅ and for "zu" I get only ず.

himselfv commented 6 years ago

You can enable kunreishiki in settings or move it to the top of the preference list if you have several romanizations enabled. For instance, I have "Kunreishiki, Hepburn" order and du becomes づ and other things work too.

himselfv commented 6 years ago

Original comment by valg.

You're right. I didn't know that, since in the old version both systems worked without me doing anything. Anyways, it works only if you put Kunreishiki before Hepburn. This way they both work, but if you order them as "Hepburn, Kunreishiki" only the first one will work perfectly for some reason, while the Kunreishiki will work only for compounds and not for しちぢつづふ.

himselfv commented 6 years ago

Okay, I think I fixed most of this, please check when you have an opportunity:

https://drive.google.com/open?id=1oPLsZE3GpwN6NaylzXJvWickx6VKIScL Exe only. https://drive.google.com/open?id=1Xne8BbENjn1mAEQqkjU3ffW1kDON8SkP Full setup.

  1. Words like 気を付けて are now properly detected.

  2. Character details are now shown even if the word panel is open (was broken).

  3. Now, regarding switching to the character list. I've added a button on the character details window called "Go to grid". Click this and you'll jump to character list with this character focused.

    I'm wary of auto-focusing the character when you switch to the grid because some users might not like their previous focus replaced. Maybe they're doing some work, switching back and forth between the grid and the editor.

    What do you think of the current solution?

himselfv commented 6 years ago

Original comment by valg.

I think it's almost perfect. I say almost because if I search 気を付けて it'll find only the compound and not the 気 (but I can go around this just by copy-pasting the word before the を), and because it doesn't recognize the "nagara" form. 気を付けながら or the simple 付けながら are properly detected as 気を付ける by the 1.67 versione, but not by the 1.97. Of course I can go around this too, but I noticed this and I'm reporting it.

I had problems installing and launching the program because of the antivirus giving false positive. I had to add it to the exceptions. Ah, and the installer installs it as 1.96 :D Anyways, thank you for your hardwork. I think I can finally upgrade to the final version :D

himselfv commented 6 years ago

Hmm... Please describe this in some more details?

  1. What do you do so that Wakan 1.67 "detects" 気を付けながら and how does that happen? I mean, if I copy-paste this into the editor and put cursor to the beginning of it, both 1.67 and 1.97 show "気を付け" in the dictionary list below. If I just type "きをつけながら" in the editor as a single word, 1.67 actually just suggests "来る" and "着る" while 1.97 gives "気を付け" so it's the reverse here! Finally, if I type "kiwotsukenagara" on a dictionary page, neither of them finds the word.

  2. Where does the installer say 1.96? Just checked, the file is called setup-1.97, it shows "This will install Wakan 1.97", the app title says "Wakan 1.97 (dev)" and it shows in uninstall as "Wakan 1.97". Are you upgrading from some older version?

  3. Regarding showing 気, thanks, fixed (will upload with other fixes later).

himselfv commented 6 years ago

Original comment by valg.

  1. It was just an example. If you write 食べながら, the program should recognize it as the verb 食べる but it doesn't.
  2. Actually I don't know. When I tried to install it, the installer asked me if I wanted to save it under the folder 1.96, but now it asks me 1.97. Nevermind.

Note: I had a problem with the function autoload last opend file at start. If the file is a .wtt it recognizes it, but if it's a .txt (created with Wakan itself) the program crashes at launch. I had to open the 1.67 version to disable the autoload option.

himselfv commented 6 years ago

Do you have "Inf" button pressed on the dictionary page? Try pressing it and typing "食べながら" in the editor again. If it's that, I'll just make it always pressed in the editor.

himselfv commented 6 years ago

Original comment by valg.

It's pressed by default, but it recognizes the word 食べながら only while typing. It can't "read" it if it's already there.

himselfv commented 6 years ago

Original comment by valg.

Why is the Dictionary unclickable in the editor? https://i.imgur.com/ue80Em4.png

Do I have to change some settings or is it accessible only from the Dictionary tab?

himselfv commented 6 years ago

I think it has always been unclickable? It should show results for the currently selected word only.

Please try 食べながら with the latest version:

https://drive.google.com/open?id=1Xne8BbENjn1mAEQqkjU3ffW1kDON8SkP Setup

https://drive.google.com/open?id=1oPLsZE3GpwN6NaylzXJvWickx6VKIScL Just wakan.exe

I couldn't catch it, but I changed some things so maybe it'll work. Maybe you could screenshot what it does instead, if it's still broken?

himselfv commented 6 years ago

Original comment by valg.

It works.

In the old version I used only the Editor tab, as I could look up in the dictionary: https://i.imgur.com/xCDjfcZ.png But, well, I can go back and forth from the Dictionary tab.

himselfv commented 6 years ago

I see... Added the button to re-enable the dictionary temporarily, like it was in 1.67

https://drive.google.com/open?id=1Xne8BbENjn1mAEQqkjU3ffW1kDON8SkP setup https://drive.google.com/open?id=1oPLsZE3GpwN6NaylzXJvWickx6VKIScL just wakan.exe

If everything is fine I'm closing the issue I guess?

himselfv commented 6 years ago

Original comment by valg.

It's perfect. You can close the issue. I don't have any more requests. Thank you so much for your work.