himselfv / wakan

Japanese and Chinese learning tool with dictionary
38 stars 7 forks source link

Editor typing suggestion deflexes words only if this option is choosen in WordLookup pane #287

Closed himselfv closed 6 years ago

himselfv commented 6 years ago

Original report by me.

Even if the pane is hidden. See #286, further comments.

In Wakan 1.67 editor suggestions always use deflexion, even though you can call up words panel and depress the "auto-deflect" button. It has no effect.

That button should either be unavailable in Editor mode and deflexions always done (easier way), or something more complicated.

Option 1. Button disabled, always deflect (when typing, when placing cursor and in auto-translation).

Option 2. Button enabled, but only has effect it the panel is shown. If it's hidden, the popup-suggestions always use deflexion.

But then we should maybe also do this to "currently selected dictionary set"?

In any case, auto-translation should always work the same and use the same dictionary set and always use deflexions.

Placing the cursor should always mind the lower pane settings, whatever settings are allowed in that mode. If we allow auto-deflex button when panel is shown, it should have effect.

For now quickly implemented Option 1.