search

himselfv / wakan

Japanese and Chinese learning tool with dictionary
36 stars 7 forks source link

HTML copy format slighly broken #288

Closed himselfv closed 6 years ago

himselfv commented 6 years ago

Original report by me.

When you paste text copied from Wakan into editors that can handle HTML inserts (certain edit boxes in Firefox, for one), it appears framed with stuff like:

--StartFragment-->
[text]
<

Some editors handle it fine though.

There's probably an indexing error somewhere in the HTML copy format header (consult https://msdn.microsoft.com/en-us/library/windows/desktop/ms649015(v=vs.85).aspx).

Once this is fixed, re-verify that pasting also continues to work (what if Wakan relied on broken indexes?)

himselfv commented 6 years ago

Fixed in #ebd1c863b6aa, it was an off-by-one error in header's StartFragment/EndFragment indexes.

HTML copy format is not used in pasting, we either use Wakan's own copy format or raw text, so no impact.

himselfv commented 6 years ago

Fix Issue 288: HTML copy format slightly broken (indexing broken)