search

himynameisdave / git-labelmaker

:flags: Manage your GitHub labels from the command line!
MIT License
575 stars 33 forks source link

Add some testing #30

Closed himynameisdave closed 7 years ago

himynameisdave commented 8 years ago

It's been too long that there aren't any tests for this... tsk tsk tsk :-1:

Jameskmonger commented 8 years ago

I think that a good solution for this would be to potentially work on a replacement project using dependency injection (so we can fully mock out all dependencies, for example inquirer, for full testing) which is fully test-driven and then replace the two.. what do you think?

himynameisdave commented 8 years ago

That sounds like a great idea, but for the scope of this issue I would just like us to have some basic tests & always write tests first as a rule of contributing

cauealvesbraz commented 7 years ago

@himynameisdave Maybe can use mockirer for mock the inquirer answers 😸

himynameisdave commented 7 years ago

Looks good to me, I will look into that!

...I mean it does have an emoji in the description so it must be good 👍 :P

cauealvesbraz commented 7 years ago

Yeaah!!! If you need any help, let me know! 🙂 Em ter, 18 de out de 2016 às 21:09, Dave Lunny notifications@github.com escreveu:

Looks good to me, I will look into that!

...I mean it does have an emoji in the description so it must be good 👍 :P

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/himynameisdave/git-labelmaker/issues/30#issuecomment-254665376, or mute the thread https://github.com/notifications/unsubscribe-auth/AGvOxcKKERP3B7-OK13XiNiu5qrKVjRSks5q1VGZgaJpZM4HfNIU .

himynameisdave commented 7 years ago

Closed by #78 and will be released in v0.9.0