Password displayed in plain text

himynameisdave / git-labelmaker

:flags: Manage your GitHub labels from the command line!

MIT License

575 stars 33 forks source link

Password displayed in plain text #42

Closed Jameskmonger closed 7 years ago

Jameskmonger commented 8 years ago

When entering your password to unlock the archived token (after you've already successfully set it), the password is displayed in plain text.

Jameskmonger commented 8 years ago

This is an Inquirer issue.

himynameisdave commented 8 years ago

Just because this is an inquirer issue doesn't mean it is complete. I will lower the priority and we'll keep this open until a safer solution can be found...

Jameskmonger commented 8 years ago

I've noticed that the issue doesn't appear on my Ubuntu machine, it only appears (occasionally) in the Windows terminal (Node 5.6.0)

himynameisdave commented 7 years ago

Just tested, I don't believe it happens to me...

screen recording 2017-04-01 at 10 59 pm

I will check it out on Windows, and will see if resolving #77 would solve this

himynameisdave commented 7 years ago

I'm fairly confident that this is fixed as of 9668673f100ab2e5bfb2721220a78fe19c01df33 when the inquirer package was updated. Input is always hidden when typing sensitive information now:

Marking this issue as closed.