himynameisdave / git-labelmaker

:flags: Manage your GitHub labels from the command line!
MIT License
575 stars 33 forks source link

Will not accept custom package file #43

Closed NewAlexandria closed 8 years ago

NewAlexandria commented 8 years ago
npm v3.6.0
node v5.6.0

Running git-labelmaker, enter my password, and choose Add Labels From Package. I'm prompted for a path. I have tried all of these (test file located at each)

packages/github_labels.json
github_labels.json
.github_labels.json

contents of file

[
  { "name": "ready", "color": "#159818" },
  { "name": "blocked", "color": "#e11d21" },
  { "name": "open comments", "color": "#eb6420" },
  { "name": "proposal-discussion", "color": "#84b6eb" },
  { "name": "question", "color": "#cc317c" },
  { "name": "On Hold", "color": "#666666" },
  { "name": "Revision Needed", "color": "#bfdadc" }
]

I hope this helps solve an issue - or improve the docs! Thanks for your help.

Jameskmonger commented 8 years ago

Hi @NewAlexandria, could you try: ./github_labels.json (in place of github_labels.json)?

caseybecking commented 8 years ago

I'm having the same issue - it keeps bouncing right back to the question for path & name of the package.

Jameskmonger commented 8 years ago

Thanks for raising this issue @NewAlexandria and @caseybecking.

himynameisdave commented 8 years ago

@Jameskmonger I wonder if they are still using a < 0.7.2 version that doesn't include this change: https://github.com/himynameisdave/git-labelmaker/pull/37

@NewAlexandria Try and re-install this package and see if it works. Thanks for raising this issue guys, we're looking into it now!

himynameisdave commented 8 years ago

Not a version issue, it is actually just not accepting anything as a JSON package entry