search

himynameisdave / git-labelmaker

:flags: Manage your GitHub labels from the command line!
MIT License
575 stars 33 forks source link

Support GitLab #48

Open TheCodeDestroyer opened 8 years ago

TheCodeDestroyer commented 8 years ago

Just a question(type), I see that most of the code refers to GitHub, but I was wondering if you are thinking of maybe supporting GitLab as well?

P.S.: The only decent NodeJS Gitlab API wrapper I found is this one, but doesn't support labels from what I can see...

himynameisdave commented 8 years ago

Short answer: yes, eventually...

It was kindly pointed out to me on Reddit that naming this project git-labelmaker when it actually only applies to GitHub was kind of a goof. So as a result I feel like in the future we should support GitLab and BitBucket, or maybe just rename this tool github-labelmaker and create a separate tool for GitLab.

Now in terms of a timeframe, I'm not going to lie there are other features we would like to add here first.

Thanks for your question!

Jameskmonger commented 8 years ago

I initially added this to the 0.9.0 milestone, but I haven't used GitLab before. I'd like to take a bit more of a look into their API.

himynameisdave commented 8 years ago

Yeah this isn't a priority for 0.9.0, I'm thinking this is a significant change that would be better for a 1.x release

TheCodeDestroyer commented 8 years ago

Since your code tightly couples to GitHub API, maybe it wouldn't be a bad idea to rename this to "github-labelmaker" and make the other two as separate projects. You probably don't want to get into the battle where one change breaks the other two and vice-versa.

Jameskmonger commented 8 years ago

I think we could potentially have this as a project which supports labelling for the different platforms, we can just let the user select which service they want to use.

dxlr8r commented 6 years ago

Would love gitlab support as well :)