search

himynameisdave / git-labelmaker

:flags: Manage your GitHub labels from the command line!
MIT License
574 stars 33 forks source link

30 labels limit #71

Closed GabrielCW closed 7 years ago

GabrielCW commented 7 years ago

If I'm not mistaken, Github paginates results for labels to 30 items by default (https://developer.github.com/v3/#pagination ?). I happen to have more than 30 labels, so when I create a package from labels, it only takes the 30 first labels.

I'll do the rest by hand, but it'll be cool if the labelmaker was able to pull all the labels.

himynameisdave commented 7 years ago

L:eyes:king into this one, thanks for reporting!

himynameisdave commented 7 years ago

~Additionally, the labels that do come back are not ordered properly/as they appear in GitHub~ 👎

Looks like they come back alphabetically actually

himynameisdave commented 7 years ago

@GabrielCW thanks for reporting.

As of version v0.9.0 (which will hopefully be finished, merged and published soon!) the new limit will be 100, which should cover most repositories.

Beyond this, if we wanted we can parse the headers.link response to see if there is any pagination and account for, but for now I think 100 is a pretty high number and should avoid people running into problems with some not being downloaded to their new package file.