himynameisdave / git-labelmaker

:flags: Manage your GitHub labels from the command line!
MIT License
574 stars 33 forks source link

Add ability to set global packages #74

Open EmmaRamirez opened 7 years ago

EmmaRamirez commented 7 years ago

This PR:

Some questions:

Sorry if this PR is a bit crude, I just wanted to actually get started with it. Obviously, it'd be awesome if I could suggestions on improving it!

himynameisdave commented 7 years ago

This is awesome, you did a great job!

giphub

Answers to above questions:

  1. Yes, I think JSON makes the most sense as that's already what's expected when the user is uploading from a package.
  2. I think for now setting one global should be okay, and later if we want we can add in support for many global packages. I could see the use case for wanting many global packages too, like maybe you'd want some for personal projects and some for work projects. For now let's stick to just one global package though, that way we can get this out faster and then iterate on it from there :)
  3. I think this should be the default behaviour, that makes it easier to quickly add your usual default labels, especially if you use the tool on a lot of different projects and always use the same set of labels. But you are right about it not being intuitive, so we we need to think of a better way to let the user know about it 🤔
Jameskmonger commented 7 years ago

My only feedback is that it doesn't appear to be very clear that it's using the default package. Maybe it should be put as the default value into the text box?

himynameisdave commented 7 years ago

@EmmaRamirez are you still working on this? If not I don't mind picking up from where you left off...