search

himynameisdave / svelte-frappe-charts

📈 Svelte bindings for frappe-charts.
https://frappe.io/charts
MIT License
308 stars 16 forks source link

How to set Chart Title, Axis Labels? #27

Closed davidscottmills closed 3 years ago

davidscottmills commented 3 years ago

Per the Frappe configuration documentation, you should be able to set a title. I'm not able to see if or how this is being done in the base component. Could you add this to the wrapper?

himynameisdave commented 3 years ago

Hey @davidscottmills, thanks for filing this issue!

You are correct about the title attribute -- this was an oversight on my part, as when I originally wrote this wrapper I don't think title existed in frappe-charts yet. Unfortunately there is no CHANGELOG for that library, and the release notes often don't contain info about new features/props like this one. 😕

This is easy to implement, we'd just need to:

Feel free to open a PR if you are feeling ambitious, otherwise I'll try to get to it this weekend. 💪

Also: The title of this issue mentions Axis Labels as well -- are there any other ones that the library is missing?

davidscottmills commented 3 years ago

Thanks for taking care of this! Do you have plans for when you'll release a new npm package?

himynameisdave commented 3 years ago

@davidscottmills should be sometime today, just wanted to investigate #26 and see if I can bundle any required changes from that issue into the same release 👍

himynameisdave commented 3 years ago

@davidscottmills here ya go: https://github.com/himynameisdave/svelte-frappe-charts/releases/tag/v1.4.0

davidscottmills commented 3 years ago

@himynameisdave Thanks! As far as the axis labels go, I don't think Frappe Charts has the ability to add axis labels. Hopefully they'll add this in the future.