search

himynameisdave / svelte-frappe-charts

📈 Svelte bindings for frappe-charts.
https://frappe.io/charts
MIT License
310 stars 16 forks source link

update frappe-charts import #31

Closed TorstenDittmann closed 3 years ago

TorstenDittmann commented 3 years ago

We should let the bundler decide what file to import 🙂

Current implementation doesn't work with Vite + Svelte + Typescript 👍🏻

himynameisdave commented 3 years ago

Thanks for reporting. This seems like a sensible change.

I would love to get more info about your build setup, as I haven't had a chance to use Vite yet. Are you using svite for this?

TorstenDittmann commented 3 years ago

Thanks for reporting. This seems like a sensible change.

I would love to get more info about your build setup, as I haven't had a chance to use Vite yet. Are you using svite for this?

I have used the default typescript template you get with yarn create @vitejs/app https://vitejs.dev/guide/#scaffolding-your-first-vite-project

It looks like it uses svite under the hood 🙂