search

himynameisdave / svelte-frappe-charts

📈 Svelte bindings for frappe-charts.
https://frappe.io/charts
MIT License
306 stars 16 forks source link

TypeScript definitions #54

Open DoodlesEpic opened 2 years ago

DoodlesEpic commented 2 years ago

Currently, the package does not provide TypeScript definitions. It would be nice if the package provided TypeScript definitions to avoid this kind of error:

Error: Could not find a declaration file for module 'svelte-frappe-charts'. '/node_modules/svelte-frappe-charts/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/svelte-frappe-charts` if it exists or add a new declaration (.d.ts) file containing `declare module 'svelte-frappe-charts';` (ts)

This should be pretty simple to do since the @types/frappe-gantt package is already available.

youknowedo commented 1 year ago

Made a PR ( #57 ) fingers crossed they review it 🤞🏾

himynameisdave commented 1 year ago

It's been reviewed now, so once the questions/code comments have been addressed and it's rebased/merged with main I am happy to merge and release this!

pieterdhondt commented 1 year ago

Any update on this?

Gbox4 commented 1 year ago

Please release types! Easy feature to add and is going to 10x the accessibility of this great library!

d3F0g commented 1 year ago

Are the types updated?

Nacir1i commented 10 months ago

any updates in this issue ?