search

himynameisdave / svelte-frappe-charts

📈 Svelte bindings for frappe-charts.
https://frappe.io/charts
MIT License
310 stars 16 forks source link

Adding in showLegend export variable #56

Open MellenIO opened 2 years ago

MellenIO commented 2 years ago

First off - thanks for this library, it's super useful!

I opened a PR for Frappe in relation to using their showLegend option - which is fully implemented, but not configurable.

You can find it here: https://github.com/frappe/charts/pull/389

I wanted to add this as a PR on the basis that it gets implemented. I don't think the library will break w/ this if the upstream PR isn't merged, but it would probably be best to only do so when upstream is merged.

Thanks!

himynameisdave commented 2 years ago

@MellenIO thanks for adding this. While I understand it wouldn't break anything here to merge this now, I would prefer to wait until it lands upstream first, as this is really just a wrapper around frappe-charts and we try to mirror their API directly.

Having said this, I know the maintainers of frappe-charts and know that they are (were?) working on a v2 release of that package soon, but I'm not sure (as I don't think @scmmishra works at Frappe anymore?). Until then we can keep this PR open, and please post in this thread once the upstream PR is merged.

Again, thanks for your contribution!