Project Feedback!

[codepathreview]

@hina0611 can you pls resubmit README properly and mark the stories you have done correctly? I noticed you haven't implemented For different news articles that only have text or only have images, use Heterogenous Layouts with RecyclerView but it is marked with [Y]. Also pls follow the correct way to submit README - https://courses.codepath.com/courses/intro_to_android/pages/submitting_assignments

[hina0611]

Sure thanks for the response.. Going to reach office and will do it ASAP. Will update u after my submission. Thanks

[codepathreview]

:+1: Good job getting all required and many optional stories done. A few notes after checking out the code:

• Great work on organising source code.
• Nice to see you used action bar for searching
• Great job implementing DialogFragment for filters.
• Good job using the ConnectivityManager to check for network availability
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Great job using RecyclerView with StaggeredGridLayoutManager
• Good job implementing Heterogeneous layouts with Recycler View
• Great work implementing MVP
• Good job using Retrofit

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation. /cc @codepathreview