search

hinok / react-router-last-location

Provides access to the last location in react + react-router (v4.x, v5.x) applications. ❤️ Using hooks? useLastLocation | 💉 Using HOC? withLastLocation
MIT License
284 stars 24 forks source link

Converting the tests from Enzyme to Testing Library. #54

Closed tigerabrodi closed 3 years ago

tigerabrodi commented 3 years ago

Hi :wave:

I recognized your library when looking for a solution that allows me to check the previous pathname. :grin:

I saw that you guys are currently using Enzyme, which itself seems to be blocking the support of React 17+.

I and many friends are a part of the Open Source Raid Guild, a group that supports OSS projects. :blue_heart:

Many of us work together on one large PR. :nerd_face:

We would fork your project to our Github Team and work on our fork, and communicate with some of the maintainers closely over at Discord.

Read more about us: https://github.com/OpenSourceRaidGuild/tutorial-quest#hi-wave-welcome-to-the-open-source-raid-guild-crossed_swords

Our discord server: https://discord.gg/JczjG8su

Let us know if you've any questions, and feel free to join the Discord already, even if it is just a question. :partying_face:

joealden commented 3 years ago

@hinok FYI this would unblock #46.

hinok commented 3 years ago

@joealden @tigerabrodi Feel free to create a PR here that will use react-testing-library instead of enzyme. I'm happy to merge it once it will be done and publish a new version.

JacobMGEvans commented 3 years ago

We will create a PR soon.

Any objections to adding more tests as well?

hinok commented 3 years ago

@JacobMGEvans The current code coverage is 99% so if you want to reach 100%, go ahead 😱 🥳

JacobMGEvans commented 3 years ago

@hinok Nearly done.

JacobMGEvans commented 3 years ago

Should have something by this weekend.