search

hinto-janai / festival

Music player
https://festival.pm
MIT License
273 stars 5 forks source link

GUI hangs forever on Windows when selecting song (media controls) #81

Open hinto-janai opened 11 months ago

hinto-janai commented 11 months ago

OS & Version

Windows x64.

Festival GUI v1.0.0 to v1.3.3.

Bug

Festival GUI hangs (stops responding) on song selection on certain Windows builds.

It is most likely blocking on souvlaki, where it is attempting to connect to the OS media controls API.

This can be confirmed by running:

.\Festival.exe --disable-media-controls

where it runs fine.

Either all of Windows 10 machines or specific machines with outdated drivers may be affected.

Steps

Steps to reproduce the behavior:

  1. Start Festival (no queue)
  2. Start playback on any song
  3. Hang forever
hinto-janai commented 11 months ago

It is hanging on this line exactly:

https://github.com/Sinono3/souvlaki/blob/384539fe83e8bf5c966192ba28e9405e3253619b/src/platform/windows/mod.rs#L188

It might have to do with the custom dummy window used.

Passing the HWND from Festival GUI is a solution, but it does not fix festivald, since it doesn't have a window.