search

hinto-janai / gupax

GUI Uniting P2Pool And XMRig
https://gupax.io
GNU General Public License v3.0
279 stars 19 forks source link

Add option to join and donate to XMRvsBeast raffle #76

Open snex opened 10 months ago

snex commented 10 months ago

Feature request

XMRvsBeast generously operates a bonus raffle over at https://xmrvsbeast.com/p2pool/

It would be cool if joining this as well as donating hashrate could be automated via Gupax. The more people donate, the bigger the rewards are for winners.

hinto-janai commented 10 months ago

I'm not familiar with how the bonus raffle works.

I'm not sure if adding a specific pool's functionality into Gupax is good either.

snex commented 10 months ago

You never have to donate in order to win the "normal" rounds. It is just free hash rate if you do win. You just have to register your address. If you choose to donate, you have more chances to win. XMRvsBeast is not another pool - it is a part of p2pool just like Gupax users are. You do have to trust that he rewards people fairly, but he has been doing so for several years now.

elstak80 commented 10 months ago

Well, will be great to have a flag to donate (not the VIP) and also to select how many threads use for the donation... will be easier for the ppl to donate. Gupax can show 2 xmrig's windows...

Cyrix126 commented 8 months ago

Hello, For reference I'm made a fork (beta is released) to integrate the XvB raffle as to complete this bounty.

Rikj000 commented 6 months ago

@Cyrix126, I noticed the bounty has been completed, thank you for your work!

Do you intend to send a PR to Gupax to merge in with upstream?
Or will Gupaxx remain a separate fork?
If the latter is true, can we expect that you will keep your fork up-to-date with upstream changes?

Cyrix126 commented 6 months ago

@Cyrix126, I noticed the bounty has been completed, thank you for your work!

Do you intend to send a PR to Gupax to merge in with upstream? Or will Gupaxx remain a separate fork? If the latter is true, can we expect that you will keep your fork up-to-date with upstream changes?

Gupax was originally funded by CCS which included maintenance lasting for end of 2023. Since then updates were mostly some bugfixes and keeping the list of nodes updated. I don't know if @hinto-janai plans to update it more. Like I explain in DIFFERENCES there are more issues that are fixed in my fork. I'm pretty sure he is busy working on Cuprate right now. Proposing a PR at this point would be a lot of work, because I completely refactored the code. I plan however to keep Gupaxx up to date in the case upstream brings new commits. You can see ideas that are thoughts for Gupaxx (subject to change).

hinto-janai commented 6 months ago

@Cyrix126 thanks for ping.

I'm pretty sure he is busy working on Cuprate right now.

Sorry about this, I haven't had much time to touch any other repo for the past few months.

Proposing a PR at this point would be a lot of work, because I completely refactored the code. I plan however to keep Gupaxx up to date in the case upstream brings new commits.

I have to say I'm impressed with Gupaxx, if I could re-write this project, I would have made many of the changes you've made.

If you want, you could rename your project and make it your own; I don't plan to add features, mostly bug fixes and node updates, so I think staying connected to upstream may hold back Gupaxx development.

Cyrix126 commented 6 months ago

Thank you for your kind words, I have to say it was a pleasure understanding your code with all the good documentation you made.

If you want, you could rename your project and make it your own

I'm willing to take the maintenance, should we discuss it in details over matrix ?

hinto-janai commented 6 months ago

@hinto:monero.social - what is your ID?

Cyrix126 commented 6 months ago

sent you an invite.