hiohiohio / omegat-plugin-externalfinder

ExternalFinder plugin for OmegaT
https://hiohiohio.github.io/
Apache License 2.0
7 stars 3 forks source link

Ampersand in URL #4

Closed marcocevoli closed 10 years ago

marcocevoli commented 10 years ago

Hi,

Whenever I try to add a new URL with an ampersand in it, the plugin fails to load in OmegaT. I've tried to encode the ampersand as %26 (percentage twenty-six), but this is taken literally (so the link doesn't work). Am I doing something wrong or is it really a bug? Thanks in advance and thanks a million for this plugin, which is exactly what I was looking for in a while. :) Marco

hiohiohio commented 10 years ago

Hi Marco,

Thank you for using this plugin and sorry for late replying (I should set something to send a notification email). Can you please try to use "&" instead of "&"?

Kind Regards, Chihiro

marcocevoli commented 10 years ago

Please add the right notation with spaces, because the editor here converts the entities... I see "&" instead of "&" ...

hiohiohio commented 10 years ago

Oh sorry. I have edited the previous comment.

Can you please try to use "&" instead of "&"?

marcocevoli commented 10 years ago

I already tried it and it doesn't work. The problem seems to be the & sign (which, of course) is present in & a m p ... :)

hiohiohio commented 10 years ago

Can you please try this item? It works for me on OSX 10.7.5 with OmegaT 3.1.4 and Windows 7 with OmegaT 2.6.3 using embedded JRE.


<item>
    <name>Google (_ja)</name>
    <url target="both" encoding="default">https://www.google.com/search?q=%22{target}%22&amp;lr=lang_ja&amp;ie=UTF-8</url>
</item>

marcocevoli commented 10 years ago

Perfect! it works on OmegaT 3.1.6 - Windows 8.1 I think I put different options in target and encoding. Could that be the reason? Thanks a million!

hiohiohio commented 10 years ago

Thank you for the feedback. I do not think the options in this context are related to the plugin loading error. Therefore, you can set any combinations of options as you want.

marcocevoli commented 10 years ago

Ok. Then I probably missed the semicolon when I first tested the URL with & a m p ;

hiohiohio commented 10 years ago

Actually, I believe this plugin still has some bugs. So if you see errors again, please let me know! I will add the URL which includes an ampersand in the example. I appreciate your feedback. Thank you.