hipages / php-fpm_exporter

A prometheus exporter for PHP-FPM.
Apache License 2.0
592 stars 119 forks source link

Update go version build to pickup patch for linux kernel bugs in go 1.14.0 #114

Closed L3o-pold closed 3 years ago

L3o-pold commented 3 years ago

Describe the bug

Seems that php-fmp-exporter is built with go 1.14.0, we should update to 1.14.6

Relevant stack trace:

runtime: mlock of signal stack failed: 12
runtime: increase the mlock limit (ulimit -l) or
runtime: update your kernel to 5.3.15+, 5.4.2+, or 5.5+
fatal error: mlock failed
and runtime stack ...
related go issue, golang/go#37436

Root cause: https://bugzilla.kernel.org/show_bug.cgi?id=205663 Affected Linux kernels: 5.2.x, 5.3.0-5.3.14, 5.4.0-5.4.1 Fixed Linux kernel 5.3.15 released at 2019-12-05: https://lwn.net/Articles/806395/ Fixed Linux kernel 5.4.2 released at 2019-12-05: https://lwn.net/Articles/806394/ Go's partial workaround: https://go-review.googlesource.com/c/go/+/209899/ We are updating go here to pickup the workaround Available Linux kernels for the latest Ubuntu release: https://packages.ubuntu.com/search?keywords=linux-image-generic Latest linux kernel available for Ubuntu is version 5.3.0 However, it seems like the patch was cherry-picked into Ubuntu's 5.3.0 kernel: https://kernel.ubuntu.com/git/ubuntu/ubuntu-eoan.git/commit/?id=59e7e6398a9d6d91cd01bc364f9491dc1bf2a426

L3o-pold commented 3 years ago

@estahn can you make a tag please?

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

estahn commented 3 years ago

@L3o-pold Apologies, the release pipeline failed. This is now available as 1.2.1.