Closed stchr closed 3 years ago
This patch break php-fpm_exporter for php 7.2.34, php 7.3.26, still have Getting request informations
and not EOL.
This patch break php-fpm_exporter for php 7.2.34, php 7.3.26, still have
Getting request informations
and not EOL.
@itcsoft54 You are right. Implemented Fallback in https://github.com/hipages/php-fpm_exporter/pull/134/commits/269acb5b9d41daa523e1d859885f2918f9e86d1c
@estahn Would be great if you can review/merge this change ✌️
@stchr Thanks for this Simon. Can you sync with the latest master? This should resolve the test issue.
@estahn master sync is done 💪
:tada: This PR is included in version 2.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
@all-contributors add @stchr for bug
@estahn
I've put up a pull request to add @stchr! :tada:
See
[FPM_REQUEST_INFO] = "Getting request information",
in https://github.com/php/php-src/blob/07fa13088e1349f4b5a044faeee57f2b34f6b6e4/sapi/fpm/fpm/fpm_request.c#L27Otherwise you can get error messages like
Unknown process state 'Getting request information'
in php-fpm_exporter. And indeed, "Getting request information" is unknown, as php-fpm_exporter is checking for "Getting request informations" (note the wrong plural "s")This was changes in PHP >= 7.4 with https://github.com/php/php-src/commit/84b195d9fc5ba2b65ceb46d8ec3d4676bf51a538
Fixes #137