search

hipages / php-fpm_exporter

A prometheus exporter for PHP-FPM.
Apache License 2.0
592 stars 119 forks source link

support config-file #154

Open lazychanger opened 3 years ago

lazychanger commented 3 years ago

93

lazychanger commented 3 years ago

@estahn i fixed issue #93 , please help me review the code

itcsoft54 commented 3 years ago

Please check if ENV is prior to values in configuration file. If not it can break the way that debian package Prometheus export (using /etc/default/.conf file for parameters) that currently use ENV prior to configuration to redefine value. Conf file seem to be load after env variables loaded, in case of define both in ENV and conf file.

lazychanger commented 3 years ago

Please check if ENV is prior to values in configuration file. If not it can break the way that debian package Prometheus export (using /etc/default/.conf file for parameters) that currently use ENV prior to configuration to redefine value. Conf file seem to be load after env variables loaded, in case of define both in ENV and conf file.

I think ENV has a higher weight than files. so you can see use mapEnvVars to override the file configuration. My english for Google Transfer. Please don't mind. Thanks for you review.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.