Add ability to allow or disable specific metrics

hipages / php-fpm_exporter

A prometheus exporter for PHP-FPM.

Apache License 2.0

604 stars 123 forks source link

Add ability to allow or disable specific metrics #175

Closed blkperl closed 3 years ago

blkperl commented 3 years ago

Would there be any interest in new configuration that allows the users to choose which metrics are sent by the exporter? I can submit a pull request.

In my use case we have thousands of pods running php-fpm and we have exceeded our quota for metrics so we want to restrict the metrics sent to the ones that are needed.

I would also be interested in #84 being completed.

blkperl commented 3 years ago

I've learned that prometheus filtering has an action: drop that can be used to accomplish the same thing.

estahn commented 3 years ago

@blkperl I think it's a good suggestion and at times more trivial compared to adjusting the scrape config. But yes Prometheus allows dropping of metrics during scraping: https://www.robustperception.io/dropping-metrics-at-scrape-time-with-prometheus