search

hipages / php-fpm_exporter

A prometheus exporter for PHP-FPM.
Apache License 2.0
604 stars 123 forks source link

Allow 10 seconds to shutdown, fixing shutdown error #204

Closed kierenevans closed 2 years ago

kierenevans commented 2 years ago

v2.0.0 and above crashes with message "Error during shutdowncontext deadline exceeded" and exit code 1 upon SIGINT being received (run and then Ctrl+C, or on our case autoscaling a kubernetes deployment down)

v1.2.1 seems to be unaffected.

Possibly due to the change in go versions from v1.14 to v1.15.

The mux graceful shutdown example in https://github.com/gorilla/mux#graceful-shutdown has a usage of the "flag" package to parse an argument into the variable, but it looks like that doesn't happen here so I think it initialised with an empty duration.

Fixes #132

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: