feat: add scrape_url as prometheus label for each metric

hipages / php-fpm_exporter

A prometheus exporter for PHP-FPM.

Apache License 2.0

604 stars 123 forks source link

feat: add scrape_url as prometheus label for each metric #72

Closed sas1024 closed 4 years ago

sas1024 commented 4 years ago

Fix #53 issue

estahn commented 4 years ago

@sas1024 Thanks for your PR. I will get the CI pipeline fixed today.

estahn commented 4 years ago

@sas1024 Can you please update with the latest master?

sas1024 commented 4 years ago

@sas1024 Can you please update with the latest master?

Sure. Done.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

sas1024 commented 4 years ago

@estahn it's seems that CI pipeline need more fixes.

estahn commented 4 years ago

@estahn it's seems that CI pipeline need more fixes.

I have migrated this to GitHub Actions and removed CircleCI.

In regards to the PR I'm wondering if this should be optional. We're running php-fpm_exporter currently as side-care and this wouldn't have any benefit.

Thoughts?

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

estahn commented 4 years ago

@all-contributors please add sas1024 for code

allcontributors[bot] commented 4 years ago

@estahn

I've put up a pull request to add @sas1024! :tada: