search

hipages / php-fpm_exporter

A prometheus exporter for PHP-FPM.
Apache License 2.0
604 stars 123 forks source link

fix: support capturing SIGTERM signal to shutdown gracefully #82

Closed stanxing closed 4 years ago

stanxing commented 4 years ago

https://github.com/hipages/php-fpm_exporter/issues/81

estahn commented 4 years ago

@stanxing Thanks for your contribution. Did you test this? I would have expected to see the shutdown message (https://github.com/hipages/php-fpm_exporter/blob/master/cmd/server.go#L115).

I tested this on MacOS.

estahn commented 4 years ago

@stanxing Thanks for your contribution. Did you test this? I would have expected to see the shutdown message (https://github.com/hipages/php-fpm_exporter/blob/master/cmd/server.go#L115).

I tested this on MacOS.

Ok, never mind. I killed go run instead of the actual process. Looks good 👍

stanxing commented 4 years ago

Ok, never mind. I killed go run instead of the actual process.

Tested on Ubuntu 18.04 with golang 1.13.4

Screenshot from 2020-03-21 11-00-24

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

estahn commented 4 years ago

@all-contributors please add stanxing for code

allcontributors[bot] commented 4 years ago

@estahn

I've put up a pull request to add @stanxing! :tada: